Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Refactor HandleRequests method on connection" #65

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

ksysoev
Copy link
Owner

@ksysoev ksysoev commented Jun 2, 2024

This pull request refactors the HandleRequests method on the connection to handleRequests. This change improves code readability and follows naming conventions.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.43%. Comparing base (f4ec718) to head (3dc5640).

Files Patch % Lines
channel/channel.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   90.63%   91.43%   +0.79%     
==========================================
  Files          20       20              
  Lines         844      829      -15     
==========================================
- Hits          765      758       -7     
+ Misses         58       52       -6     
+ Partials       21       19       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksysoev ksysoev marked this pull request as ready for review June 2, 2024 13:36
@ksysoev ksysoev merged commit 6d3569f into main Jun 2, 2024
1 check passed
@ksysoev ksysoev deleted the 63-refactor-connection-interface branch June 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants